gbn+mailbox: cleanup & prefixed logger #90
Conversation
ellemouton
force-pushed
the
gbnCleanup
branch
7 times, most recently
from
0daa526
to
47b022c
Compare
There was a problem hiding this comment.
Thanks a lot for this!! This will be really, really helpful 🙏:fire:!!
Left a few comments below, but also leaving one extra feedback here:
Should we change the mailbox/server_conn.go & mailbox/client_conn.go to also use a prefixed logger? Those structs currently have quite a few log calls that adds a separate "Server" & "Client" prefix.
Also, should I change my packeting bug PRs to be based on this already?
ellemouton
force-pushed
the
gbnCleanup
branch
3 times, most recently
from
5fa6e72
to
ef7b4fc
Compare
There was a problem hiding this comment.
Thanks @ViktorTigerstrom ! Added the prefixed logger for the mailbox package as you suggested 🙏
Yeah I think that would be a good idea just so that you get the advantages of the prefixed logger & so that you can take advantage of the slightly cleaner GBN structure. You can change the base of you PR to |
Instead of manually needing to insert "isServer=" everywhere.
ellemouton
force-pushed
the
gbnCleanup
branch
from
ef7b4fc
to
65256cb
Compare
ellemouton
force-pushed
the
gbnCleanup
branch
from
65256cb
to
72e5adf
Compare
This PR introduces a prefixed logger which is then passed to the client and server so that
their logs are prefixed with
(client)and(server)so that we dont have to manually usethe
isServervariable in logs.Then, some variables are moved out of the GBN struct and into a new
configstruct.depends on #92